Subject: | hii friend , I found your article... |
Summary: | Package rating comment |
Messages: | 3 |
Author: | Gayan Chathuranga |
Date: | 2011-02-04 14:53:25 |
Update: | 2011-02-07 15:44:46 |
|
|
|
Gayan Chathuranga rated this package as follows:
Utility: | Sufficient |
Consistency: | Sufficient |
Examples: | Not sure |
Unit tests: | Not sure |
|
 Gayan Chathuranga - 2011-02-04 14:53:25
hii friend ,
I found your article important and did go through normalizations which are described in RFC 3986 . it could be found apart from "symentic changing normalization" , you have missed some of "semantic preserving normalizations" listed below as well and please check them out .
Removing the Default port
Adding trailing
thnks
Rgds,
Gayan Chathuranga
 Glen Scott - 2011-02-04 15:45:50 - In reply to message 1 from Gayan Chathuranga
Hi Gayan,
Thank you for your comments. You are correct, currently the class does not handle the normalization steps detailed in section 6.2.3 of RFC 3986. I will add this note to the README file, and will add this functionality in the future.
Kind regards,
Glen
 altainta - 2011-02-07 15:44:46 - In reply to message 2 from Glen Scott
Hello
it came to my notice that there is a error on line 12 of
URLNormalizerTest.php
$this->fixture =& new URLNormalizer();
is it
$this->fixture = new URLNormalizer();
I noticed that when phpdesigner 7 warned me about it..
it says
'Assigning the return value of new by reference is deprecated'
Kindly take a look
|